not all symfony packages updated #24723
Replies: 17 comments 4 replies
-
|
when i run |
Beta Was this translation helpful? Give feedback.
-
|
The ones you say are not updated are indirect dependencies? |
Beta Was this translation helpful? Give feedback.
-
|
If you wanted to manually update all symfony packages from 4.2.5 to 4.2.7 - and not update any non-symfony packages - which commands would you run to do it? |
Beta Was this translation helpful? Give feedback.
-
|
as an example |
Beta Was this translation helpful? Give feedback.
-
|
@BigMichi1 I think you and I are thinking along the same lines now. I agree that you should ideally have all symfony packages on the same version in a project, and in fact maybe in some cases you "must" have them all on the same. But when they're deeply nested packages inside the lock file, I'm not sure how you'd achieve this - whether as a bot or as a human. If you update every dependency in the lock file then you might end up changing 10x more versions than just symfony. Longer term the solution is that Renovate would have the capability to update nested dependencies in lock files, but by default have that functionality would be disabled because it would be too noisy otherwise. Then in cases like this you could have the capability to turn nested updates on just for symfony packages. |
Beta Was this translation helpful? Give feedback.
-
|
The issue occurs when Symfony does a major or minor version upgrade. Renovate correctly updates the require and require-dev sections, but there is another part in composer.json that also needs to be changed because it restricts the maximum allowed version of the symfony/* packages: "extra": {
"symfony": {
"allow-contrib": false,
// This should match the version of Symfony packages in the require/require-dev sections
"require": "5.1.*" // <---
}
}These links explain in more detail: |
Beta Was this translation helpful? Give feedback.
-
|
@msheakoski good find, thanks. I'm confused though because the docs for this I was trying to work out if this extra field is used by other packages or just symfony ones. If we are trying to solve symfony alone, would it work if we treat |
Beta Was this translation helpful? Give feedback.
-
|
@rarkins The symfony/flex package registers a composer plugin which uses the configuration in composer.json's I'm not an expert in this domain, but I believe that the version in The question is how to determine what the latest major/minor/patch version of Symfony is. Because |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@nicolas-grekas Interesting, I always wondered how that worked! @rarkins I think that it would be safe to treat Packages like |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @msheakoski @nicolas-grekas. Yes, it seems like we can use The next question I have is whether we need to modify Renovate's default installation of https://github.com/renovatebot/docker-buildpack/blob/master/src/php/build/composer.sh |
Beta Was this translation helpful? Give feedback.
-
|
@rarkins It should work without any changes to the buildpack. If |
Beta Was this translation helpful? Give feedback.
-
|
Great. Last remaining step: can someone create a simple public repo that reproduces the current Renovate not working correctly? |
Beta Was this translation helpful? Give feedback.
-
|
Late to the party, but recently hit this bug/missing feature, and found this thread while researching the cause. I created a test repo which reproduces this issue:
In the PR above, |
Beta Was this translation helpful? Give feedback.
-
|
@rarkins Can we transfer this discussion to an issue? Or do you want me to create a new issue for this? |
Beta Was this translation helpful? Give feedback.
-
|
Please create a new discussion, category "Suggest an Idea". The idea should be that Renovate takes into account symfony compatibility when suggesting changes. The reproduction should also conform with Renovate's current reproduction template (e.g. expected vs observe behavior). It can be converted into an issue once the feasibility and requirements are fully specified (e.g. where Renovate finds the symfony requirements from, how it can determine symfony compatibility during the lookup phase, etc). |
Beta Was this translation helpful? Give feedback.
-
|
I created #31910 |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
|
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide. The Renovate team |
Beta Was this translation helpful? Give feedback.
-
What Renovate type are you using?
Renovate CLI
Describe the bug
i have a php/composer project which is based on the symfony skeleton. in my composer.json i have currently this
when i now run renovate it results in a merge request (want's to update 4.2.5 to 4.2.7) for only the specified symfony packages from
composer.json. so the update in thecomposer.lockfile still contains other symfony packages with the old version. also the version in the extra section is not updated to the new one.Did you see anything helpful in debug logs?
To Reproduce
Expected behavior
composer.jsoncomposer.lockScreenshots
none available
Additional context
currently i'm using renovate in version 16.0.4
Beta Was this translation helpful? Give feedback.
All reactions