You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think most of the code is compatible with poetry 2.0. To check, I forked this repo and modified the CI to run pytest against poetry 2.0.1. After my changes (eb84c14...1adf781), the CI test completed successfully:
There was, however, one small change that I had to make!
The __init__() method in poetry's Config class appears to have changed recently. It has one fewer parameter. So I changed one of the methods in plugin.py:
Hi @aryarm, thank you for working on this. I'm very much open to supporting Poetry 2. I took a quick look and the changes look reasonable. Would you mind opening a PR? I'll review it and let you know if there are any further changes necessary, or, if you prefer, I could push those changes too.
Thanks
I'm happy to open a PR. In that case, I'll also revert my changes to the CI and lock file, since I'm not really sure if you want to test against poetry 2.0 in the same way that I did
Hi @renan-r-santos,
First of all, thank you so much for creating this plugin. I've been using it in many of our projects for a while now, and it has been very useful!
I'm writing to inquire about the possibility of removing the
poetry<2
upper bound requirement in the pyproject.toml file?poetry-conda/pyproject.toml
Line 30 in eb84c14
I think most of the code is compatible with poetry 2.0. To check, I forked this repo and modified the CI to run
pytest
against poetry 2.0.1. After my changes (eb84c14...1adf781), the CI test completed successfully:https://github.com/aryarm/poetry-conda/actions/runs/12815790474/job/35735262753
There was, however, one small change that I had to make!
The
__init__()
method in poetry's Config class appears to have changed recently. It has one fewer parameter. So I changed one of the methods inplugin.py
:poetry-conda/src/poetry_conda/plugin.py
Line 33 in eb84c14
Thanks in advance for any consideration of this!
The text was updated successfully, but these errors were encountered: