[Bug]: Basename is duplicated when calling setSearchParams

[ms-tng]

What version of React Router are you using?

6.11.0

Steps to Reproduce

1. Start a React app using this code:

import { useEffect } from "react";
import ReactDOM from "react-dom/client";
import { Route, RouterProvider, createBrowserRouter, createRoutesFromElements, useSearchParams } from "react-router-dom";

const Foo = () => {
  const [_, setSearchParams] = useSearchParams();

  useEffect(() => {
    setSearchParams({
      bar: "baz",
    });
  }, [setSearchParams]);

  return null;
};

const router = createBrowserRouter(
  createRoutesFromElements(<Route path="/foo" element={<Foo />} />),
  { basename: "/base" }
);

ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render(
  <RouterProvider router={router} />
);

2. Configure your server to serve the app from /base, e.g. with this Vite config:

import react from "@vitejs/plugin-react";
import { defineConfig } from "vite";

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [react()],
  server: {
    base: "/base",
  },
});

3. Open /base/foo in your browser, e.g. with the default Vite port: http://127.0.0.1:5173/base/foo

Expected Behavior

The app should redirect to http://127.0.0.1:5173/base/foo?bar=baz

This is what happens with [email protected].

Actual Behavior

The app redirects to http://127.0.0.1:5173/base/base/foo?bar=baz

I.e. the /base part is duplicated. In React's strict mode, when everything is rendered twice in development, it even redirects to http://127.0.0.1:5173/base/base/base/foo?bar=baz

[brophdawg11]

Thanks for the reproduction @ms-tng! Looks like we missed a stripBasename call when we moved the relative routing/basename handling inside the @remix-run/router

[brophdawg11]

This is fixed by #10433 and should be available once 6.11.1 is released

[github-actions]

🤖 Hello there,

We just published version 6.11.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 6.11.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[ms-tng]

Works perfectly, thank you for the quick fix! 👍