[Bug?]: Missing parameter for route when using glob pattern

[richcatt]

What's not working?

I'm trying to change a couple of routes to use the glob param pattern, in order to work with nested items, e.g.:

<Route path='/category/{categoryIds...}/edit' page={CategoryEditCategoryPage} name='editCategory' />

This working fine when I manually enter the URL, but I get an error when creating navigate links, e.g.:

<Link to={routes.editCategory({ 'categoryIds...': category.id })}>Edit</Link>

How do we reproduce the bug?

https://gitpod.io#snapshot/f051b363-f867-42e0-8153-8c300d52439e

Navigate to categories list - https://8910-redwoodjs-gitpodstarter-im8r4cjqmdr.ws-eu63.gitpod.io/categories

What's your environment? (If it applies)

System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.13.2 - /tmp/xfs-12e552be/node
    Yarn: 3.2.0 - /tmp/xfs-12e552be/yarn
  Databases:
    SQLite: 3.31.1 - /usr/bin/sqlite3
  npmPackages:
    @redwoodjs/core: 2.2.3 => 2.2.3

Are you interested in working on this?

• I'm interested in working on this

[richcatt]

I'm assuming the syntax for the navigate link is as above, although if I remove the ... the app loads and functions correctly, e.g.:

<Link to={routes.editCategory({ 'categoryIds': category.id })}>Edit</Link>

However, I then get a TS error:

TS2345: Argument of type ‘{ categoryIds: any; }’ is not assignable to parameter of type ‘{ “categoryIds…”: string; } & QueryParams’. Property ‘“categoryIds…”’ is missing in type ‘{ categoryIds: any; }’ but required in type ‘{ “categoryIds…”: string; }’.

[jtoar]

Hey @cattre thanks for the Gitpod snapshot! 🚀 As you mentioned in your second comment it looks like the types Redwood generates wrong. Let me step through babel-plugin-redwood-routes-auto-loader to see exactly what's going on there.

[jtoar]

The generator also need updating so that the page it generates doesn't throw; it needs a parameter.

[jtoar]

So turns out the utility type here doesn't handle glob routes, so this now very much a TS problem

[nbushe]

I had this problem because of a link without a parameter in the layout.