Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error stack trace missing from api side log formatter when masking GraphQL errors #5010

Closed
dthyresson opened this issue Apr 3, 2022 · 0 comments · Fixed by #5704
Closed
Assignees
Labels
bug/confirmed We have confirmed this is a bug topic/graphql topic/logging

Comments

@dthyresson
Copy link
Contributor

A fix for the logger was made after the GraphQL Yoga release that reinstated the error message when an error is masked in th GraphQL Server: #4912

That PR was favored over #4902 which has a similar fix.

The 4912, however, the original error's full stack trace is no longer output when logging.

While the error message is provided, the stack trace on the api side can be helpful in tracking down the line that raised the error and help debug and fix.

The approach in 4902 should be revisited as it adds to complete original error details into the error -- and should check that the RedwoodLogger presented that stack trace as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/graphql topic/logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants