Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old nodejs target used for rw scripts #3999

Closed
Tobbe opened this issue Dec 23, 2021 · 2 comments · Fixed by #4258
Closed

Old nodejs target used for rw scripts #3999

Tobbe opened this issue Dec 23, 2021 · 2 comments · Fixed by #4258
Assignees
Labels
bug/confirmed We have confirmed this is a bug topic/core

Comments

@Tobbe
Copy link
Member

Tobbe commented Dec 23, 2021

I'm on 0.39, so apologies if this is fixed in newer versions

I'd like to be able to use replaceAll and other modern JS features in my rw scripts.

image

The screenshot above shows a rw script I'm editing.

Can/should we control this in tsconfig?

@jtoar jtoar moved this from New to Needs discussion in Triage Jan 5, 2022
@jtoar jtoar added bug/needs-info More information is needed for reproduction v1/for-consideration topic/core and removed triage/processing labels Jan 5, 2022
@jtoar jtoar moved this from Needs discussion to Needs confirmation in Triage Jan 24, 2022
@jtoar jtoar added bug/confirmed We have confirmed this is a bug and removed bug/needs-info More information is needed for reproduction labels Jan 24, 2022
@jtoar
Copy link
Contributor

jtoar commented Jan 24, 2022

I was able to reproduce this on v0.42. But I think it's just a linting error. I tried the example on mdn in a script and it worked:

// scripts/replace.ts

export default async () => {
  const p = 'The quick brown fox jumps over the lazy dog. If the dog reacted, was it really lazy?'
  console.log(p.replaceAll('dog', 'monkey'))
}

You're probably right about it being a tsconfig setting. We use replaceAll a lot in the framework so I'll see what we do there.

@jtoar jtoar removed this from Triage Jan 24, 2022
@jtoar jtoar moved this to In progress in Release Jan 24, 2022
@jtoar jtoar added this to Release Jan 24, 2022
@jtoar jtoar self-assigned this Jan 24, 2022
@jtoar jtoar moved this from In progress to Done in Release Jan 25, 2022
@jtoar jtoar moved this from Done to Archived in Release Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/core
Projects
No open projects
Status: Archived
Development

Successfully merging a pull request may close this issue.

2 participants