From 89a02cd32ba21d5c06edcbb31baf0efb1c1561af Mon Sep 17 00:00:00 2001 From: David Price Date: Sun, 27 Aug 2023 13:37:02 -0700 Subject: [PATCH] fix: resolves Tailwind setup command failing due to unsupported prettier-plugin-tailwindcss v0.5 (#9076) fixes #9075 `prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins the version to `0.4.1`, which is the most recent version prior to v0.5. **NOTE:** This issue will still affect all previous versions of Redwood because the setup ui tailwindcss command defaults to adding the Tailwind deps at latest. ### Next Steps I'll open two PRs, one to revert this and one to upgrade Prettier to v3 (both for next major). --- __fixtures__/test-project/web/package.json | 2 +- packages/cli/src/commands/setup/ui/libraries/tailwindcss.js | 2 +- tasks/test-project/tasks.js | 2 +- tasks/test-project/tui-tasks.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/__fixtures__/test-project/web/package.json b/__fixtures__/test-project/web/package.json index 1784837b53e1..c219ec494819 100644 --- a/__fixtures__/test-project/web/package.json +++ b/__fixtures__/test-project/web/package.json @@ -25,7 +25,7 @@ "autoprefixer": "^10.4.14", "postcss": "^8.4.27", "postcss-loader": "^7.3.3", - "prettier-plugin-tailwindcss": "^0.4.1", + "prettier-plugin-tailwindcss": "0.4.1", "tailwindcss": "^3.3.3" } } diff --git a/packages/cli/src/commands/setup/ui/libraries/tailwindcss.js b/packages/cli/src/commands/setup/ui/libraries/tailwindcss.js index 89d1f7fa609e..d7b1ce953817 100644 --- a/packages/cli/src/commands/setup/ui/libraries/tailwindcss.js +++ b/packages/cli/src/commands/setup/ui/libraries/tailwindcss.js @@ -115,7 +115,7 @@ export const handler = async ({ force, install }) => { }) const rwPaths = getPaths() - const projectPackages = ['prettier-plugin-tailwindcss'] + const projectPackages = ['prettier-plugin-tailwindcss@0.4.1'] const webWorkspacePackages = [ 'postcss', diff --git a/tasks/test-project/tasks.js b/tasks/test-project/tasks.js index 30657bdd7cca..7a62ffe69ffa 100644 --- a/tasks/test-project/tasks.js +++ b/tasks/test-project/tasks.js @@ -297,7 +297,7 @@ async function webTasks(outputPath, { linkWithLatestFwBuild, verbose }) { // @NOTE: use rwfw, because calling the copy function doesn't seem to work here task: () => execa( - 'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss', + 'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss@0.4.1', [], getExecaOptions(outputPath) ), diff --git a/tasks/test-project/tui-tasks.js b/tasks/test-project/tui-tasks.js index 27a4bb74daa2..35630c0c6110 100644 --- a/tasks/test-project/tui-tasks.js +++ b/tasks/test-project/tui-tasks.js @@ -337,7 +337,7 @@ async function webTasks(outputPath, { linkWithLatestFwBuild }) { // @NOTE: use rwfw, because calling the copy function doesn't seem to work here task: async () => { await exec( - 'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss', + 'yarn workspace web add -D postcss postcss-loader tailwindcss autoprefixer prettier-plugin-tailwindcss@0.4.1', [], getExecaOptions(outputPath) )