Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript declaration files should use top-level import/export. #149

Closed
threehams opened this issue Jul 6, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@threehams
Copy link
Collaborator

There's a long discussion in microsoft/TypeScript#4665 about this. We can prevent possible global pollution problems by removing module declarations, and just using plain old ES6 import/exports within reselect.d.ts, as long as the first statement in the file is import or export.

Plus, it's a lot more familiar, since it directly mirrors ES6 modules.

@aikoven
Copy link
Contributor

aikoven commented Mar 10, 2017

Resolved in #224.

@aikoven aikoven closed this as completed Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants