Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add describe log dirs request #15

Closed
weeco opened this issue Oct 23, 2019 · 2 comments
Closed

Add describe log dirs request #15

weeco opened this issue Oct 23, 2019 · 2 comments
Assignees
@weeco
Labels
backend feature New feature or request

Comments

@weeco
Copy link
Contributor

weeco commented Oct 23, 2019

In order to get more details about kafka partitions (such as their size) Kafka offers an admin request called "DescribeLogDirs". Sarama does not implement this request/response, but as it offers very valuable information we should add that request/response to Sarama.

The original Kafka documentation does not document the protocol but refers to the implementation:

Response package: https://github.com/apache/kafka/blob/05ba5aa00847b18b74369a821e972bbba9f155eb/clients/src/main/java/org/apache/kafka/common/requests/DescribeLogDirsResponse.java

Request package:
https://github.com/apache/kafka/blob/05ba5aa00847b18b74369a821e972bbba9f155eb/clients/src/main/java/org/apache/kafka/common/requests/DescribeLogDirsRequest.java
@weeco weeco added feature New feature or request backend labels Oct 23, 2019
@weeco weeco self-assigned this Oct 23, 2019
@weeco weeco mentioned this issue Oct 26, 2019
Closed
2 tasks
@weeco
Copy link
Contributor Author

weeco commented Oct 27, 2019

PR submitted: IBM/sarama#1520

@weeco
Copy link
Contributor Author

weeco commented Oct 28, 2019

PR is meged.

@weeco weeco closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weeco weeco

Labels
backend feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weeco