Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .duplicate() on Redis.Cluster #921

Closed
SGrondin opened this issue Jul 8, 2019 · 2 comments
Closed

Support .duplicate() on Redis.Cluster #921

SGrondin opened this issue Jul 8, 2019 · 2 comments

Comments

@SGrondin
Copy link
Contributor

SGrondin commented Jul 8, 2019

Hi,

This issue brought to my attention that client.duplicate() does not exist if the client was created with new Redis.Cluster({ ... }).

It seems trivial to add and I don't mind making a PR for it, but I'd like to know if it's intentional or an oversight before spending time on this!

Thank you
@SGrondin SGrondin mentioned this issue Jul 8, 2019
Closed
@luin
Copy link
Collaborator

luin commented Jul 11, 2019

Thanks for pointing this out. It doesn't exist on Cluster simply because we forgot to add it 🤣. PR is welcome.

@SGrondin SGrondin mentioned this issue Jul 14, 2019
Merged
@SGrondin
Copy link
Contributor Author

This was added in #926 and released in v4.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luin @SGrondin