You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently internal.Logger is defined as being *log.Logger; a pointer to a struct. This makes it impossible to use a custom logger. We either have to live with the stdlib logger or disable logging (or implement some awful hacks involving the writer).
All that is used throughout the library however is Printf(...). Therefore I propose to instead define a slim interface with only the method required and use that. The stdlib logger can still be the default, but at least it's possible then to easily replace it with a truly custom implementation.
The text was updated successfully, but these errors were encountered:
Currently
internal.Logger
is defined as being*log.Logger
; a pointer to a struct. This makes it impossible to use a custom logger. We either have to live with the stdlib logger or disable logging (or implement some awful hacks involving the writer).All that is used throughout the library however is
Printf(...)
. Therefore I propose to instead define a slim interface with only the method required and use that. The stdlib logger can still be the default, but at least it's possible then to easily replace it with a truly custom implementation.The text was updated successfully, but these errors were encountered: