Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bare metal" pull request #854 might be preventing Vale from running #856

Closed
emteelb opened this issue Aug 7, 2024 · 3 comments
Closed

Comments

@emteelb
Copy link
Contributor

emteelb commented Aug 7, 2024

Closed pull request #854 seems to be causing an issue with running the Vale prose linter. Here is an example linting from stdin:

$ lbv "bare metal is the way to go"
E201 Invalid value [/vale_app/styles/RedHat/TermsErrors.yml:22:4]:

  21    "(?<!self-)hosted engine|hosted-engine": self-hosted engine
  22*   "bare metal( clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal $1
  23    "bare-metal(?! clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare metal
  24    "[bB]asic [aA]uth": Basic HTTP authentication|Basic authentication

capture group not supported; use '(?:' instead of '('

Execution stopped with code 1.

Here, lbv is a local alias for running Vale from a Docker container. I rebuilt this container today after the pull request was committed and got this error. If I take the container's "sync" step back to a locally cached version from before the pull request, the error goes away. The sync step I believe "grabs" packaged style rules. I don't know if that is significant here or not.

Hope this report is helpful and that I have provided enough details. Happy to do more if needed.

@aireilly
Copy link
Member

aireilly commented Aug 9, 2024

Can you give me more information? This error is because you are using an older version of vale in your container. For example:

$ podman run quay.io/rhdevdocs/devspaces-documentation vale -v
vale version 3.7.0

You need Vale 3.7+ in your container

@aireilly
Copy link
Member

aireilly commented Aug 9, 2024

@emteelb
Copy link
Contributor Author

emteelb commented Aug 9, 2024

Ah! Indeed, that is the problem for me. My container was based on an older Vale version (jdkato/vale:v2.x.x). Thank you for the reply and apologies for the noise.

@emteelb emteelb closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants