Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep consistent style in notification when prompted to restart/reload VSCode #2585

Closed
yuyully opened this issue Jul 21, 2022 · 1 comment · Fixed by #2594
Closed

Keep consistent style in notification when prompted to restart/reload VSCode #2585

yuyully opened this issue Jul 21, 2022 · 1 comment · Fixed by #2594
Labels
typing
Milestone
End August 2022

Comments

@yuyully
Copy link

yuyully commented Jul 21, 2022

Environment
  • Operating System: Mac intel
  • JDK version: 17.0.2
  • Visual Studio Code version: 1.69.2
  • Java extension version: 1.9.0
Steps To Reproduce
  1. [step 1] Change java.jdt.ls.java.home in settings > Notification dialog shows as screenshot 1
  2. [step 2] Install a new extension, like debugger for java > Notification dialog shows as screenshot 2
Current Result

Screenshot 1:
image
Screenshot 2:
image

Expected Result

As restart and reload work in a same way, better to only keep one, both reload or both restart.
@jdneo jdneo added the typing label Jul 21, 2022
@jdneo
Copy link
Collaborator

jdneo commented Jul 21, 2022

We can consider make those wordings consistent in next iteration.

@jdneo jdneo mentioned this issue Jul 25, 2022
Merged
@jdneo jdneo added this to the End August 2022 milestone Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typing
Projects
None yet
Milestone
End August 2022
Development

Successfully merging a pull request may close this issue.

Make the wording in notifications consistent jdneo/vscode-java
2 participants
@jdneo @yuyully