Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toString Generator shows fields in wrong order #2502

Closed
quochuyhl99 opened this issue Jun 10, 2022 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2212
Closed

toString Generator shows fields in wrong order #2502

quochuyhl99 opened this issue Jun 10, 2022 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2212
Labels
bug code action
Milestone
End September 2022

Comments

@quochuyhl99
Copy link

quochuyhl99 commented Jun 10, 2022 •
edited
Loading

Environment
  • Operating System: Windows 10
  • JDK version: 17
  • Visual Studio Code version: 1.68.0
  • Java extension version: 0.23.0
Description

toString Generator shows fields in the wrong order leading to code generated in the wrong order too.

Untitled

Expected result:

Fields should show in correct order like the constructor.

Untitled1
@jdneo
Copy link
Collaborator

jdneo commented Jun 10, 2022 •
edited
Loading

@CsCherrYY Looks like another code action ux related issue. Guess you might be interested in this. :)

@jdneo jdneo mentioned this issue Aug 23, 2022
Closed
@CsCherrYY
Copy link
Contributor

we now get the candidate list via ITypeBinding.getDeclaredFields(): https://github.com/eclipse/eclipse.jdt.ls/blob/726ece1d1fd26480028c217f1d27193f4cd05760/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JdtDomModels.java#L60

The return array seems to not be in particular order. Maybe IType.getFields() returns the correct definition order.

@CsCherrYY CsCherrYY mentioned this issue Sep 5, 2022
Merged
@rgrunber rgrunber added this to the End September milestone Sep 15, 2022
@rgrunber rgrunber added the bug label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code action
Projects
None yet
Milestone
End September 2022
Development

Successfully merging a pull request may close this issue.

Show toString()/hashCode() and equals() fields in definition order CsCherrYY/eclipse.jdt.ls
4 participants
@rgrunber @jdneo @CsCherrYY @quochuyhl99