-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support inlay hints #2099
support inlay hints #2099
Comments
It's also supported in Eclipse since 4.12 (2019-06) https://www.eclipse.org/eclipse/news/4.12/jdt.php#parameter-name-codemining. I don't think we can use the class since it's in UI and ICodeMining is tied to some UI rendering elements. However the AST logic is pretty straightforward to copy over, or we could refactor the relevant parts we need in JDT. |
I have adopted VS Code for full time java IDE, I love it, just this one feature I am missing. |
I think we should watch out for things like https://bugs.eclipse.org/bugs/show_bug.cgi?id=568844 , and maybe look at possible solutions. The jumpiness is caused when a method temporarily can't be resolved to a proper signature (due to syntax error?) and then switches to resolved. The effect is annotations flickering which affect the user's ability to type. |
Update: inlay hint is available as client side API in VS Code 1.65.0. Maybe we can first make a client side implementation. I can volunteer for that. :) |
It's available in IntelliJ IDEA,
https://www.jetbrains.com/help/idea/inlay-hints.html
Supported in TS/JS since vscode v1.60
![image](https://user-images.githubusercontent.com/2351748/132154259-4d47251d-3945-4fec-9ca7-3c8715d150de.png)
See: https://code.visualstudio.com/updates/v1_60#_inlay-hints-for-javascript-and-typescript
Proposed API in VS Code:
https://github.com/microsoft/vscode/blob/997228d528d687fd17cbf3ba117a0d4f668c1393/src/vs/vscode.proposed.d.ts#L1773-L1793
LSP proposal:
microsoft/language-server-protocol#956
The text was updated successfully, but these errors were encountered: