diff --git a/pkg/deploy/deploy.go b/pkg/deploy/deploy.go index cf533b97a09..9a7dcbceba9 100644 --- a/pkg/deploy/deploy.go +++ b/pkg/deploy/deploy.go @@ -88,7 +88,6 @@ func (o *deployHandler) ApplyKubernetes(kubernetes v1alpha2.Component) error { // Execute will deploy the listed information in the `exec` section of devfile.yaml // We currently do NOT support this in `odo deploy`. func (o *deployHandler) Execute(command v1alpha2.Command) error { - // TODO: Handle cases where `odo deploy` is run again and the job still exists: ✗ unable to create Jobs: jobs.batch "demo-app" already exists containerComps, err := generator.GetContainers(o.devfileObj, common.DevfileOptions{FilterByName: command.Exec.Component}) if err != nil { return err @@ -156,7 +155,7 @@ func (o *deployHandler) Execute(command v1alpha2.Command) error { jobLogs, logErr := o.kubeClient.GetJobLogs(createdJob, command.Exec.Component) if logErr != nil { - log.Warningf("failed to fetch the logs required to identify the reason for execution failure; cause: %s", logErr) + log.Warningf("failed to fetch the logs of execution; cause: %s", logErr) } else { fmt.Println("Execution output:") logErr = util.DisplayLog(false, jobLogs, log.GetStderr(), o.componentName, -1) diff --git a/pkg/kclient/interface.go b/pkg/kclient/interface.go index 5ae38c2b250..9e6e386a108 100644 --- a/pkg/kclient/interface.go +++ b/pkg/kclient/interface.go @@ -166,7 +166,7 @@ type ClientInterface interface { // CreateJobs creates a K8s job to execute task CreateJobs(job batchv1.Job, namespace string) (*batchv1.Job, error) - // WaitForJobToComplete to wait until a job completes or fails; it starts printing log or error if the job does not complete execution after 2 minutes + // WaitForJobToComplete to wait until a job completes or fails; it starts printing log or error if the job does not complete execution after 1 minute WaitForJobToComplete(job *batchv1.Job) (*batchv1.Job, error) // GetJobLogs retrieves pod logs of a job GetJobLogs(job *batchv1.Job, containerName string) (io.ReadCloser, error)