Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fact capture to common. #211

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Move fact capture to common. #211

merged 1 commit into from
Jul 11, 2024

Conversation

jeffmcutter
Copy link
Collaborator

In order to avoid potential drift of the data between analysis and upgrade for debugging issues during upgrade.

@jeffmcutter
Move fact capture to common.
a77df07 
In order to avoid potential drift between analysis and upgrade for debugging issues during upgrade.
@jeffmcutter jeffmcutter mentioned this pull request Jul 11, 2024
Closed
djdanielsson
djdanielsson approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was just for trying to run without analysis I would probably push back but I do think there is a case to be made that it should happen right before the upgrade as you said to prevent the chance of drift

@djdanielsson djdanielsson merged commit 5e9aac2 into redhat-cop:main Jul 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdanielsson djdanielsson djdanielsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffmcutter @djdanielsson