From 5b990b9dc264bbc09b119068bf60fe216c445ee4 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sat, 16 Nov 2024 13:15:51 +0100 Subject: [PATCH] add test for double assign removal --- .../Fixture/fixture.php.inc | 49 +++++++++++++++++++ .../KeepDoubleAssignParamTest.php | 28 +++++++++++ .../config/configured_rule.php | 12 +++++ 3 files changed, 89 insertions(+) create mode 100644 tests/Issues/KeepDoubleAssignParam/Fixture/fixture.php.inc create mode 100644 tests/Issues/KeepDoubleAssignParam/KeepDoubleAssignParamTest.php create mode 100644 tests/Issues/KeepDoubleAssignParam/config/configured_rule.php diff --git a/tests/Issues/KeepDoubleAssignParam/Fixture/fixture.php.inc b/tests/Issues/KeepDoubleAssignParam/Fixture/fixture.php.inc new file mode 100644 index 00000000000..e782968637a --- /dev/null +++ b/tests/Issues/KeepDoubleAssignParam/Fixture/fixture.php.inc @@ -0,0 +1,49 @@ +items = [$input]; + } else { + $this->items = $input; + } + + $this->items = $this->getItems(); + } + + public function getItems() + { + return sort($this->items); + } +} + +?> +----- +items = !\is_array($input) ? [$input] : $input; + + $this->items = $this->getItems(); + } + + public function getItems() + { + return sort($this->items); + } +} + +?> diff --git a/tests/Issues/KeepDoubleAssignParam/KeepDoubleAssignParamTest.php b/tests/Issues/KeepDoubleAssignParam/KeepDoubleAssignParamTest.php new file mode 100644 index 00000000000..4cbe0f9c96e --- /dev/null +++ b/tests/Issues/KeepDoubleAssignParam/KeepDoubleAssignParamTest.php @@ -0,0 +1,28 @@ +doTestFile($filePath); + } + + public static function provideData(): Iterator + { + return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); + } + + public function provideConfigFilePath(): string + { + return __DIR__ . '/config/configured_rule.php'; + } +} diff --git a/tests/Issues/KeepDoubleAssignParam/config/configured_rule.php b/tests/Issues/KeepDoubleAssignParam/config/configured_rule.php new file mode 100644 index 00000000000..1ae93deb1a6 --- /dev/null +++ b/tests/Issues/KeepDoubleAssignParam/config/configured_rule.php @@ -0,0 +1,12 @@ +withRules([ + \Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector::class, + \Rector\DeadCode\Rector\Assign\RemoveDoubleAssignRector::class, + \Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector::class, + ]);