Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImproveDoctrineCollectionDocTypeInEntityRector doesn't support indexedBy #357

Closed
yguedidi opened this issue Dec 20, 2024 · 2 comments · Fixed by #359
Closed

ImproveDoctrineCollectionDocTypeInEntityRector doesn't support indexedBy #357

yguedidi opened this issue Dec 20, 2024 · 2 comments · Fixed by #359
Assignees
@samsonasik

Comments

@yguedidi
Copy link
Contributor

It seems ImproveDoctrineCollectionDocTypeInEntityRector always add int index in the generic PHPdoc.
But when we use indexedBy, we can have `string indexes.
@samsonasik
Copy link
Member

duplicated with rectorphp/rector#8791

@samsonasik
Copy link
Member

btw, it should be indexBy over indexedBy

@samsonasik samsonasik mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsonasik samsonasik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use normal Collection<ClassName> when property has indexBy rectorphp/rector-doctrine
2 participants
@samsonasik @yguedidi