Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Upgrade fastai to v2 #1992

Closed
SimonYansenZhao opened this issue Sep 13, 2023 · 2 comments
Closed

[FEATURE] Upgrade fastai to v2 #1992

SimonYansenZhao opened this issue Sep 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@SimonYansenZhao
Copy link
Collaborator

SimonYansenZhao commented Sep 13, 2023 •
edited
Loading

Description

fastai has breaking changes in v2, which makes the code in recommenders incompatible with fastai v2. For example, CollabDataBunch is removed in fastai v2.

Expected behavior with the suggested feature

It should be compatible with fastai v2 because fastai v1 is not maintained.

Other Comments

There are 3 repos related to fastai:

See also
@SimonYansenZhao SimonYansenZhao added the enhancement New feature or request label Sep 13, 2023
@miguelgfierro
Copy link
Collaborator

@SimonYansenZhao do you think this issue is fixed?

@SimonYansenZhao
Copy link
Collaborator Author

@SimonYansenZhao do you think this issue is fixed?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelgfierro @SimonYansenZhao