Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt PHPUnit attributes #1167

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Adopt PHPUnit attributes #1167

merged 3 commits into from
Feb 24, 2025

Conversation

duncanmcclean
Copy link
Contributor

@duncanmcclean duncanmcclean commented Feb 24, 2025 •
edited
Loading

Summary

This pull request updates the test suite to adopt PHPUnit attributes, over metadata/comments which are deprecated in PHPUnit 11.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@duncanmcclean duncanmcclean marked this pull request as ready for review February 24, 2025 16:58
@duncanmcclean duncanmcclean mentioned this pull request Feb 24, 2025
Merged
11 tasks
mfn
mfn approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, attributes are awesome!

@mfn mfn merged commit 3e5091a into rebing:master Feb 24, 2025
28 of 29 checks passed
@duncanmcclean duncanmcclean deleted the phpunit-attributes branch February 24, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanmcclean @mfn