-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use unicode escape in native reason #2337
Comments
What's your backing version of ocaml? ( As I recall it requires a minimum version of OCaml 4.06 (but it might have been 4.06.1 or 4.07?). |
@OvermindDL1 even if OCaml has support for it we need to actually implement it in the Reason lexer. |
I tested here on OCaml 4.07.1 + Reason 3.4.0. |
I stumbled upon this in Revery package.json, so it's looks like ocaml version is alright |
Thanks for the report. @hcarty Do you know how to fix this in the Reason lexer? I think that's where this fix would go. And then it would get backported to all previous ocaml compiler versions automatically when using Reason. |
@jordwalke I think the ocaml/ocaml#1232 PR's code could be reused almost directly. I think using that code, though, would require someone with consortium license access to pull it in in order to keep things friendly with Reason's MIT license. |
fixed in #2738 |
I can't get how to use unicode escaping in reason
i'm writing
let oghamSpace = "\u{1680}";
looking at this PR ocaml/ocaml#1232but i'm getting
Warning 14: illegal backslash escape in string.
The text was updated successfully, but these errors were encountered: