Skip to content

Commit 6262158

Browse files
dannysufacebook-github-bot
authored andcommitted
Pass StackTrace directly to Hermes ConsoleMessage
Summary: Hermes' ConsoleMessage constructor now accepts StackTrace, so the construction can be done in one go. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D56738060 fbshipit-source-id: 709b47d8f9cf69994e4c5eaa4f9310e70a4d9ed0
1 parent 7b3c622 commit 6262158

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,10 @@ class HermesRuntimeTargetDelegate::Impl final : public RuntimeTargetDelegate {
143143
hermesStackTrace = std::move(**hermesStackTraceWrapper);
144144
}
145145
HermesConsoleMessage hermesConsoleMessage{
146-
message.timestamp, type, std::move(message.args)};
147-
// NOTE: HermesConsoleMessage should really have a constructor that takes a
148-
// stack trace.
149-
hermesConsoleMessage.stackTrace = std::move(hermesStackTrace);
146+
message.timestamp,
147+
type,
148+
std::move(message.args),
149+
std::move(hermesStackTrace)};
150150
cdpDebugAPI_->addConsoleMessage(std::move(hermesConsoleMessage));
151151
}
152152

0 commit comments

Comments
 (0)