[C++] Make MediaDriver keepalive exception consistent #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont think my change could've broken atomicArrayUpdaterTest in C++ Xcode (macOS) build. |
reissGRVS
commented
Feb 23, 2023
| { | ||
| m_driverActive = false; | ||
|
|
||
| int64_t age = m_driverProxy.timeOfLastDriverKeepalive() + m_driverTimeoutMs; |
There was a problem hiding this comment.
Another annoying thing about this was the two separate calls to timeOfLastDriverKeepalive().
In theory it could've changed in between and you end up logging a nonsense "age"
Makes the keepalive timeout exception consistent with implementation in aeron_client_conductor_check_liveness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the keepalive timeout exception consistent with implementation in aeron_client_conductor_check_liveness
https://github.com/real-logic/aeron/blob/master/aeron-client/src/main/c/aeron_client_conductor.c#L381-L393