Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:<> doesn't support key from metadata #401

Closed
Deraen opened this issue Oct 3, 2018 · 2 comments
Closed

:<> doesn't support key from metadata #401

Deraen opened this issue Oct 3, 2018 · 2 comments
Assignees

Comments

@Deraen
Copy link
Member

Deraen commented Oct 3, 2018

[:<> {:key "1"} ...] works.

^{:key "1"} [:<> ...] doesn't work.

@Deraen Deraen added the bug label Oct 3, 2018
@Deraen Deraen self-assigned this Oct 3, 2018
@frankitox
Copy link

Hey @Deraen. Is this already fixed? I'm just browsing through the code and saw in the definition of fragment-element that is looking for the key in both places. Also runned a little snippet such as:

[:table
         [:tbody
          [:tr
           (doall
            (for [index (range 5)]
              ^{:key (str index)} [:td (str index)]))]]]

without any warning.

@Deraen Deraen closed this as completed in 62f8729 Nov 14, 2018
@Deraen
Copy link
Member Author

Deraen commented Nov 14, 2018

fragment-element had bug with oset call so the object with key was not passed to React.

Your example isn't related to this issue at all as it is not used Fragment shortcut :<>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants