Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical borders in table headers look visually unpleasing in Firefox #581

Closed
rohieb opened this issue Feb 22, 2018 · 5 comments
Closed

Comments

@rohieb
Copy link

rohieb commented Feb 22, 2018

Problem

Vertical borders in table headers look visually unpleasing when viewed with Firefox, and disturb the reader by attracting attention to them. Screenshot of the current behaviour:

54e3f9e6-17e0-11e8-a873-6f5da530dbd1

Reproducible Project

Any example that produces tables with headers, for example in https://sphinx-rtd-theme.readthedocs.io/en/latest/demo/lists_tables.html

Expected Results

Vertical borders in table headers look visually more pleasing and don't disturb the reader. This could be reached by coloring them the same as all the other table cell borders, for example, by adding a simple CSS rule:

.rst-content table.docutils thead th, .rst-content table.field-list thead th {
    border-color: #e1e4e5;
}

I was not able to find out what the respective change on the SASS side was.

Screenshot:
a2e263bc-17e0-11e8-aaab-ab3c26dc6131

Environment Info

  • RTD Theme Version: latest
@tuukkamustonen
Copy link

I've seen this also, but looks like it's already fixed in the latest build? Cannot see the problem at https://sphinx-rtd-theme.readthedocs.io/en/latest/demo/lists_tables.html anymore?

@rohieb
Copy link
Author

rohieb commented Mar 22, 2018

@tuukkamustonen
Copy link

Checked again: you're right, it's like that on Firefox, but fixed on Chrome/Opera (Webkit).

@rohieb
Copy link
Author

rohieb commented Mar 23, 2018

Oh right, I can confirm this!

@rohieb rohieb changed the title Vertical borders in table headers look visually unpleasing. Vertical borders in table headers look visually unpleasing in Firefox Mar 23, 2018
@rohieb
Copy link
Author

rohieb commented Mar 24, 2018

Thanks a lot, @jessetan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants