Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable repository URL is incorrect with git scheme #2085

Closed
agjohnson opened this issue Mar 24, 2016 · 7 comments
Closed

Clickable repository URL is incorrect with git scheme #2085

agjohnson opened this issue Mar 24, 2016 · 7 comments
Labels
Bug A bug Good First Issue Good for new contributors

Comments

@agjohnson
Copy link
Contributor

When a project has a URL scheme of git://..., the clickable link is instead linked to git//..., which will result in a copied link of http://git//...

@agjohnson agjohnson added the Bug A bug label Mar 24, 2016
@etataurov
Copy link

This is caused by Django's urlize filter. Not sure what the best fix would be. Custom filter?

@humitos
Copy link
Member

humitos commented Dec 28, 2017

I just imported this repository to my local instance: git//github.com/humitos/turtle-confusion-es.git and the links to Edit or View in github work great.

The problem is in the project home page at RTD, http://localhost:8000/projects/turtle-confusion/,

captura de pantalla_2017-12-28_10-44-15

the URL linked there is: http://git//github.com/humitos/turtle-confusion-es.git

What should be the solution? Just replace the git:// sheme by https:// or what?

@humitos humitos added the Good First Issue Good for new contributors label Jan 28, 2018
@stsewd
Copy link
Member

stsewd commented Jan 28, 2018

I think this doesn't need to be a link, instead just show as normal text (maybe with some style as background). Something like GitHub does.

gh

Given that this link is basically the clone url of the repo, not the project page, and there is already a field for that.

@humitos
Copy link
Member

humitos commented Jan 29, 2018

@stsewd mmm... Interesting. In the case that we don't want to make it a link, I'd say that we need to reorder them by showing the "Home Page" first and then "Repository" (excactly in the opposite order than now)

On the other hand, in the case of Github it makes sense to not be a link since you want to copy and clone the repo, but I think that use case is not applicable to RTD. I mean, I suppose that not many RTD users clone repos from RTD; but they may explore the repo more often.

@stsewd
Copy link
Member

stsewd commented Jan 29, 2018

@humitos if the repo is from GitLab, Bitbucket or GitHub, we could get a link, but if it is a public repo from other service (or a custom GitLab installation for example), what could we do then?

We also could generate the home page link when the project is created (in case of the known services). What do you think?

@stsewd
Copy link
Member

stsewd commented Mar 8, 2018

@humitos now I came with a more simple solution p:. What about just checking the protocol? If it's https?:// we put a link, otherwise, just plain text.

@humitos
Copy link
Member

humitos commented Mar 9, 2018

@stsewd I like the idea; if you want to propose a PR, I can review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Good First Issue Good for new contributors
Projects
None yet
Development

No branches or pull requests

4 participants