-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable repository URL is incorrect with git
scheme
#2085
Comments
This is caused by Django's |
I just imported this repository to my local instance: The problem is in the project home page at RTD, the URL linked there is: http://git//github.com/humitos/turtle-confusion-es.git What should be the solution? Just replace the |
@stsewd mmm... Interesting. In the case that we don't want to make it a link, I'd say that we need to reorder them by showing the "Home Page" first and then "Repository" (excactly in the opposite order than now) On the other hand, in the case of Github it makes sense to not be a link since you want to copy and clone the repo, but I think that use case is not applicable to RTD. I mean, I suppose that not many RTD users clone repos from RTD; but they may explore the repo more often. |
@humitos if the repo is from GitLab, Bitbucket or GitHub, we could get a link, but if it is a public repo from other service (or a custom GitLab installation for example), what could we do then? We also could generate the home page link when the project is created (in case of the known services). What do you think? |
@humitos now I came with a more simple solution p:. What about just checking the protocol? If it's |
@stsewd I like the idea; if you want to propose a PR, I can review it :) |
When a project has a URL scheme of
git://...
, the clickable link is instead linked togit//...
, which will result in a copied link ofhttp://git//...
The text was updated successfully, but these errors were encountered: