Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify HTMLFile and ImportedFile models #10729

Open
stsewd opened this issue Sep 13, 2023 · 0 comments
Open

Unify HTMLFile and ImportedFile models #10729

stsewd opened this issue Sep 13, 2023 · 0 comments
Labels
Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Sep 13, 2023 •
edited by humitos
Loading

What's the problem this feature will solve?

We have these two models (HTMLfile is just a proxy model of ImportedFile), but we no longer need to have them separate since we will be removing the dependency on django-elasticsearch-dsl (#10730), and we don't track files that aren't html anyway.

Describe the solution you'd like

Just use ImportedFile in our codebase.

Alternative solutions

Just deal with having two classes for the same thing.

Additional context

#10696
@stsewd stsewd added the Improvement Minor improvement to code label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stsewd