Skip to content

Commit d4ce77c

Browse files
committed
Build: use same version of setuptools when using system_packages (#10287)
The same version installed before needs to match here. Fixes #10285
1 parent 51f189c commit d4ce77c

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

readthedocs/doc_builder/python_environments.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,8 @@ def install_core_requirements(self):
248248
# even if it is already installed system-wide (and
249249
# --system-site-packages is used)
250250
cmd.append('-I')
251-
# If this flag is present,
252-
# we need to cap setuptools again.
253-
# See https://github.com/readthedocs/readthedocs.org/issues/8775
254-
requirements.append('setuptools<58.3.0')
251+
# The same version of setuptools used above needs to be used here.
252+
requirements.append(setuptools_version)
255253
cmd.extend(requirements)
256254
self.build_env.run(
257255
*cmd,

readthedocs/rtd_tests/tests/test_doc_building.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def test_install_core_requirements_sphinx_system_packages_caps_setuptools(self,
451451
"sphinx-rtd-theme",
452452
"readthedocs-sphinx-ext",
453453
"jinja2<3.1.0",
454-
"setuptools<58.3.0",
454+
"setuptools",
455455
]
456456

457457
self.assertEqual(self.build_env_mock.run.call_count, 2)

0 commit comments

Comments
 (0)