Skip to content

Commit 7b258d5

Browse files
committed
added comment: CryptoPP BlockPaddingSchemeDef::DEFAULT_PADDING is equal to PKCS_PADDING which is in fact PKCS#7 (not #5) because AES CBC Block Size > 8
1 parent 1f01c0c commit 7b258d5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/lcp-client-lib/AesCbcSymmetricAlgorithm.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ namespace lcp
9696
dataLength,
9797
decryptedData,
9898
decryptedDataLength,
99-
BlockPaddingSchemeDef::DEFAULT_PADDING
99+
BlockPaddingSchemeDef::DEFAULT_PADDING // == PKCS_PADDING => PKCS#7 (AES CBC Block Size > 8)
100100
);
101101
}
102102

@@ -118,7 +118,7 @@ namespace lcp
118118
inBuffer.size(),
119119
&outBuffer.at(0),
120120
outBuffer.size(),
121-
BlockPaddingSchemeDef::DEFAULT_PADDING
121+
BlockPaddingSchemeDef::DEFAULT_PADDING // == PKCS_PADDING => PKCS#7 (AES CBC Block Size > 8)
122122
);
123123

124124
return static_cast<size_t>(stream->Size())
@@ -170,7 +170,7 @@ namespace lcp
170170
size_t sizeWithoutPaddedBlock = plainTextSize - (plainTextSize % CryptoPP::AES::BLOCKSIZE);
171171
if (rangeInfo.position + rangeInfo.length > sizeWithoutPaddedBlock)
172172
{
173-
padding = BlockPaddingSchemeDef::DEFAULT_PADDING;
173+
padding = BlockPaddingSchemeDef::DEFAULT_PADDING; // == PKCS_PADDING => PKCS#7 (AES CBC Block Size > 8)
174174
}
175175

176176
// Read data from the stream

0 commit comments

Comments
 (0)