feat(form): add forms and form element components

[TheSharpieOne]

#50

Forms and form element components as well as docs and tests including:

• Form
• FormGroup
• FormFeedback
• FormText
• Input
• Label

What this doesn't include for forms:

• input-group and input-group-addon
• something about grouping radio and checks (this seems like something twbs is changing in v4 (new .form-check vs .radio and .check) half of their docs use or the other)
• custom forms (Is this new to bs4, don't think I have seen this before)
• fieldsets (doesn't seem like it would be useful since everything would just pass right though <Fieldset disabled> -> <fieldset disabled>

Also, these are the basic building block components, there are no helper/wrapping components (like a single component which will build out a form group with a label and an input for you.) The helper/wrapping components can utilize these, if you determine this library should have such components (in which case, let me know and I can add them).

I did the best I could with docs, there are a lot of examples which shows everything, but not everything has a dedicated section.

[coveralls]

Coverage remained the same at 100.0% when pulling 4d77d28 on TheSharpieOne:feature/forms into 257f378 on reactstrap:master.

[byennen]

👍

[eddywashere]

Apologies for the delay in reviewing this. It was a bigger pr and I didn't have a large block of time until today.

• I think the examples are sufficient until it becomes clearer in bootstrap docs. either way it could be improved in another pr
• Custom forms is definitely new.
• Just read up on fieldset caveats in the docs. That could have been the default tag for FormGroup. Seems great for modern browsers, but might be more trouble than it's worth.

re: "Also, these are the basic building block components, there are no helper/wrapping components"

I usually put together something like that for projects I'm working on. ex: forms, I usually have a formgroup, error and validation wrapped components (tailored to app ux). If they exist, they should be part of another repo like reactstrap-helpers. It would be a good reference for people learning how to piece things together.

[eddywashere]

I wasn't sure why this would ever happen but then I remembered the static text class. 👍

[eddywashere]

A few comments. Great work!

[eddywashere]

consider adding {...attributes} after htmlFor={htmlFor}, I could imagine someone not using for and sticking with htmlFor, in which case it would be overridden with a falsey attribute.

[TheSharpieOne]

Sorry about the copy-pasta with the exported component name. I'll clean these up Monday.

As for taking select and textarea out, would it be acceptable to leave them in and create convenience components called Select and Textarea which simply wrap Input to set the type? I believe it will make this project's code a bit cleaner (imho, since then there will not be components which do the similar thing except for output a different tag) and more clear for the dev user (seeing Select instead of Input type="select") while also making it easy if they Inputs are dynamically created (by the dev user via some config and custom things they set up (no need for a switch to determine which component to use, always Input).

[eddywashere]

Hmmm. That's a fair point. There would still be a switch for type and props assigned. In that case, no need to include Select & Textarea in this pr. If it's a big enough problem it can be addressed in a later pr without a breaking change. Removing it after it existed would be a breaking change.

[coveralls]

Coverage remained the same at 100.0% when pulling b22fe5a on TheSharpieOne:feature/forms into 257f378 on reactstrap:master.

[coveralls]

Coverage remained the same at 100.0% when pulling cf8196e on TheSharpieOne:feature/forms into 2252f6f on reactstrap:master.

[TheSharpieOne]

/me kicks travis

[coveralls]

Coverage remained the same at 100.0% when pulling 2b495ef on TheSharpieOne:feature/forms into 2252f6f on reactstrap:master.

[eddywashere]

👍