Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Add validation for URL Shortener buttons and fix placeholder visibility issue #1575

Closed
4 of 5 tasks
anuj-kumary opened this issue Nov 27, 2024 · 1 comment · Fixed by #1577
Closed
4 of 5 tasks
Assignees
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🏁 status: ready for dev Ready for work

Comments

@anuj-kumary
Copy link
Contributor

anuj-kumary commented Nov 27, 2024

Descrcibe the bug?

In the current implementation of the URL Shortener, the following issues need to be addressed:

  1. Validation for the "Shorten URL" button: The API is called even when the input field is empty.
  2. Validation for the "Copy to Clipboard" Button: The button is enabled even without a valid shortened URL, allowing users to copy empty or invalid data.
  3. User Experience Issue with Placeholder Text: The placeholder text in the input field is not fully visible; the text appears cut off, impacting usability and clarity for users.

Steps to reproduce the bug?

  1. Navigate to the URL Shortener page.
  2. Leave the input field empty.
  3. Click the "Shorten URL" button.
  4. Observe that the API is called even with no input.
  5. Without generating a shortened URL, click the "Copy to Clipboard" button.
  6. Observe that the button attempts to copy empty or invalid data.
  7. Look at the url shortener input field placeholder text and notice that it is partially visible or appears cut off.click the "Copy to Clipboard" button without generating a shortened URL

Expected behavior

  • For the "Shorten URL" button:

    • Button should be disabled if the input field is empty.
  • For the "Copy to Clipboard" button:

    • Be hidden by default (when no shortened URL is generated).
    • Become visible only when a valid shortened URL is present.
  • For the Input Field Placeholder:

    • Placeholder text should be fully visible and readable.
    • Adjust styling (e.g., padding, font size, or input box dimensions) to prevent text clipping.

Desktop (Please provide your system information)

OS: macOS
Browser: Chrome

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

Screenshot 2024-11-27 at 1 12 36 PM

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@anuj-kumary anuj-kumary added bug Something isn't working 💻 aspect: code Concerns the software code in the repository 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Nov 27, 2024
Copy link

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🏁 status: ready for dev Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants