Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Styling Issue with Contributors Page #1521

Closed
3 of 5 tasks
Shivam-Katare opened this issue Oct 1, 2024 · 16 comments · Fixed by #1565
Closed
3 of 5 tasks

🐛 [Bug report]: Styling Issue with Contributors Page #1521

Shivam-Katare opened this issue Oct 1, 2024 · 16 comments · Fixed by #1565
Assignees
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix hacktoberfest 🏁 status: ready for dev Ready for work

Comments

@Shivam-Katare
Copy link
Contributor

Descrcibe the bug?

The contributor's page does not display the full image of the user. The image is cut off at the top.

image

When clicking on the badges (if available), the modal/dialog box opens on the left side. It should open in the center of the screen.

image

The text inside that modal should be in markdown format.

Instead of showing ReactPlay(https://reactplay.io/), it should display ReactPlay with clickable links.

The page is also not responsive, but it should be.

image

Steps to reproduce the bug?

  1. Go to the ReactPlay site
  2. Click on the browse button
  3. Open any play
  4. Click on the Creator of that Play(the steps are shown below now...)
r.-.Trim.mp4

Expected behavior

  • The cut-off image should be properly visible
  • The page must be responsive
  • The modal should open at the center of the screen
  • The text inside the modal must be in markdown format with clickable links.

Desktop (Please provide your system information)

Browser: Chrome
OS: Windows

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

No response

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Shivam-Katare Shivam-Katare added bug Something isn't working 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Goutamchoudhary907
Copy link

I want to work on this , can you assign this to me

@priyankarpal
Copy link
Member

priyankarpal commented Oct 2, 2024

I want to work on this , can you assign this to me

Unfortunately, you can only work one issue at a time,so other contributors can work.

@RohitMangale
Copy link

I'd like to contribute to this issue. Could you please assign it to me and add the Hacktoberfest tag?

@priyankarpal
Copy link
Member

I'd like to contribute to this issue. Could you please assign it to me and add the Hacktoberfest tag?

sure

@priyankarpal priyankarpal added 🏁 status: ready for dev Ready for work and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 2, 2024
@KrishDave1
Copy link
Contributor

I can work on this issue.Can you assign this to me?

@priyankarpal
Copy link
Member

@RohitMangale Since there haven't been any updates, we will have to unassign this issue from you.

@priyankarpal
Copy link
Member

I can work on this issue.Can you assign this to me?

assigned to you

@KrishDave1
Copy link
Contributor

On looking at the issue myself, I see that the image being cutoff is no longer the case.Also, modal is also centered properly.Should I go ahead and change the other 2 for this issue?

@priyankarpal
Copy link
Member

On looking at the issue myself, I see that the image being cutoff is no longer the case.Also, modal is also centered properly.Should I go ahead and change the other 2 for this issue?

@Shivam-Katare

@Shivam-Katare
Copy link
Contributor Author

Shivam-Katare commented Oct 12, 2024

Yes, @KrishDave1 you're correct, it's no longer a case now. So, yes you can work on the other two issues with this page.

These ones:

The text inside that modal should be in markdown format.

Instead of showing ReactPlay(https://reactplay.io/), it should display ReactPlay with clickable links.

The page is also not responsive, but it should be.

@PriteshKiri
Copy link
Contributor

Hey @KrishDave1,

Any updates on the issue ?

@KrishDave1
Copy link
Contributor

Hey @KrishDave1,

Any updates on the issue ?

Was a bit busy before 2 days.Will do it in 1-2 days

@KrishDave1
Copy link
Contributor

@Shivam-Katare @PriteshKiri So there are 2 ways to solve this problem.
1)We can convert the entire description in markdown text.Here the database will have to be updated to incorporate the markdown format.
2)I can hardcode for just the links I see(i.e ReactPlay link , Nhost link , and stackstream link).
I can do any of these.Please suggest which approach should be done

@KrishDave1
Copy link
Contributor

@PriteshKiri @Shivam-Katare Please mention which approach I should take.Thanks

@Shivam-Katare
Copy link
Contributor Author

Hey @KrishDave1, you can go for a 2nd approach, which is hardcoding the links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix hacktoberfest 🏁 status: ready for dev Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants