feat: toPromise removed.
#6598
Merged
feat: toPromise removed.
#6598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
approved these changes
Sep 15, 2021
BREAKING CHANGE: `toPromise` has been removed from `Observable`. As a workaround, use `firstValueFrom` and `lastValueFrom` functions, which can be imported from `rxjs`. For example `source$.toPromise()` would be `lastValueFrom(source$)`. In the case that you know your source only has one value, we recommend using `firstValueFrom(source$)`.
benlesh
force-pushed
the
v8-remove-toPromise
branch
from
8a55c8d to
a19f3a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
toPromisehas been removed fromObservable. As a workaround, usefirstValueFromandlastValueFromfunctions, which can be imported fromrxjs. For examplesource$.toPromise()would belastValueFrom(source$). In the case that you know your source only has one value, we recommend usingfirstValueFrom(source$).