-
Notifications
You must be signed in to change notification settings - Fork 24
Error running "yarn run toolbox" #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you sure the version is |
Yes, I'm using 2.0.0-beta.4 The problem is the path, where windows drive name is doubled 'C:\C:\Users...' |
Damn, I don't have a Windows OS to try it out. Mabye cross-env? |
I can't test it, sorry. Sure it's related to |
Also, how do I add the ThemeProvider with the existing router Provider? The index.js looks like this: const store = configureStore(); // Create an enhanced history that syncs navigation events with the store render( I am omitting the html angle brackets just for display purpose. |
Checked the 1.0.1 version Running "yarn toolbox" returns
c:/users/b/dev/custom-cra/src/App.js with imports:
Running npm start (yarn start)
|
Apparently there is a problem in the way paths are resolved in the package that breaks in Windows. Again, I don't own a Windows machine so I can't try out what I dig. Need help for this :) @Rajiv-Kulkarni It looks like you are processing the imported CSS with |
I am using react-slingshot and it has sass-loader installed already. I am not a webpack savvy, so if someone could let me know how to avoid using sass-loader and use css-loader with css files, would be great. Portion of the webpack looks like this: Thanks and appreciate. |
The import for the TimePicker is |
I fixed that and getting the results above. Not on button click though. Not sure how you get to display the time picker on button click. |
Javi, if I post my project here on github, would you be able to take a look at it and let me know what I am doing wrong? I think I added everything according to the instructions (except for the output property in the package.json which I did not understand). I am running Windows 7 by the way. Thanks. |
I guess I am stupid. Beginning to understand what this is about. No need to say "Please ignore me", since I see you folks already have. :) |
Sorry @Rajiv-Kulkarni, I was keeping myself away from the laptop during Christmas. You can run Internally, we are just requiring CSS so your module bundler needs to support it enable CSS Modules resolution. Without this setup, you can't really use RT in an easy way. This packages allows to skip the whole setup. Take into account that you in RT you can require files in two different ways: requiring css (import from index.js for each component) or requiring the component itself. For this to work you need to use the latter. I hope you get it working. I'm keeping the issue open because it is actually a bug running in Windows. If you have more doubts try to reach using Discord of in Stackoverflow. I'll be happy to help but I may need some time :) |
@javivelasco I'm trying to use this utility on Windows and ran into the same issue. I attempted some troubleshooting but wasn't very successful. I don't think the path issue is in your code, I'm inclined to think it might be an issue with postcss, but I'm not sure where. Trying to debug/troubleshoot transpiled code is a pain in the ass, haha. Maybe that helps in trying to track it down, or maybe you're familiar enough with postcss to give me some pointers on where to look in their codebase for how it resolves items like |
@mattzuba I'm going to release a new version without the css modules import. It was just removed because it was troublesome. Can you try it out when it's published? |
Sure will, can't wait! I've been banging my head against a wall trying to figure out how postcss or one of it's plugins handles :include() statements! |
I know 😁 It's a well known bug with pathnames in css modules! That's why I removed it in react-toolbox. I need to write a Changelog for the release so I'll try to publish tomorrow, thanks! |
hey @javivelasco - this issue seems to be fixed with beta.5 of react-toolbox now, thanks! Now there's just issue #11 that is cropping up. |
Great! That's fixed too :) |
Not sure if this is react-toolbox-themr related, but I'm getting error while running "yarn run toolbox"
[email protected]
[email protected]
It generates pubic/react-toolbox/theme.js and theme.css, but I'm getting error when running "yarn start"
Thanks
The text was updated successfully, but these errors were encountered: