feat: implement useRenderCount hook
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I had a quick look at the code. Seems OK so far. I'll do a more thorough review later. I think it would be more correct english to call the hook Running the workflows on this now. @xobotyi What do you think about this hook? |
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 60 61 +1
Lines 1036 1041 +5
Branches 163 163
=======================================
+ Hits 1032 1037 +5
Misses 2 2
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xobotyi
requested changes
Oct 27, 2022
There was a problem hiding this comment.
- You havent updated
README.md index.tsis missing reexport of this hook- You should add note within migrating-from-react-use.story.mdx
ArttuOll
reviewed
Oct 27, 2022
xobotyi
changed the title
useRenderCount
xobotyi
force-pushed
the
use-renders-count
branch
from
6716782 to
47d7ce0
Compare
xobotyi
changed the title
useRenderCountuseRenderCount hook
ArttuOll
approved these changes
Nov 19, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2022
# [19.2.0](v19.1.0...v19.2.0) (2022-11-20) ### Features * implement `useRenderCount` hook ([#990](#990)) ([efbeeb1](efbeeb1))
|
🎉 This PR is included in version 19.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What new hook does?
useRendersCount tracks component's renders count including the first render.
#33
Checklist