Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useLifecycleLogger): rework hook and improve tests coverage #868

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix(useLifecycleLogger): rework hook and improve tests coverage #868

merged 3 commits into from
Jul 4, 2022

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jul 4, 2022

What new hook does?

Improved code quality and tests coverage

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the ✨ enhancement New feature or request label Jul 4, 2022
@xobotyi xobotyi self-assigned this Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #868 (893118c) into master (ea4545b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #868      +/-   ##
===========================================
+ Coverage   99.90%   100.00%   +0.09%     
===========================================
  Files          59        58       -1     
  Lines        1000      1003       +3     
  Branches      178       181       +3     
===========================================
+ Hits          999      1003       +4     
+ Partials        1         0       -1
Impacted Files Coverage Δ
src/useLifecycleLogger/useLifecycleLogger.ts 100.00% <100.00%> (ø)
src/__tests__/navigator.vibrate.ts
src/useHookableRef/useHookableRef.ts 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97926fc...893118c. Read the comment docs.

@xobotyi xobotyi merged commit bfba4c2 into master Jul 4, 2022
@xobotyi xobotyi deleted the improve-useLifecycleLogger branch July 4, 2022 09:46
github-actions bot pushed a commit that referenced this pull request Jul 4, 2022
@semantic-release-bot
chore(release): 15.0.1 [skip ci]
7a8412c 
## [15.0.1](v15.0.0...v15.0.1) (2022-07-04)

### Bug Fixes

* **useLifecycleLogger:** rework hook and improve tests coverage ([#868](#868)) ([bfba4c2](bfba4c2))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 4, 2022

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xobotyi xobotyi

Labels
✨ enhancement New feature or request released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xobotyi