fix(useMediaQuery): fix state stuck for concurrent mode #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
- Coverage 99.89% 99.89% -0.01%
==========================================
Files 58 58
Lines 991 982 -9
Branches 177 173 -4
==========================================
- Hits 990 981 -9
Partials 1 1
Continue to review full report at Codecov.
|
In concurrent mode along with strict mode - synchronous mql state fetch leads to state stuck. The only way to fix that behaviour is to switch back to fully asynchronous code. Upsides - way simpler code, and reduced amount of it. Due to changes `useScreenOrientation` also affected. fix #849 BREAKING CHANGE: `useMediaQuery` and `useScreenOrientation` are asynchronous now and yields `undefined` at very first render, but updates to actual value right after.
xobotyi
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
# [15.0.0](v14.7.1...v15.0.0) (2022-07-04) ### Bug Fixes * **useMediaQuery:** fix state stuck for concurrent mode ([#866](#866)) ([75db2b5](75db2b5)), closes [#849](#849) ### Features * implement `useControlledRerenderState` hook ([#865](#865)) ([ea4545b](ea4545b)) * **useToggle:** ignore react events passed to state setter ([#867](#867)) ([085f711](085f711)), closes [#861](#861) ### BREAKING CHANGES * **useToggle:** `useToggle` now ignores react events passed to its state setter, so it can be used as event handler directly. * **useMediaQuery:** `useMediaQuery` and `useScreenOrientation` are asynchronous now and yields `undefined` at very first render, but updates to actual value right after.
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In concurrent mode along with strict mode - synchronous mql state fetch
leads to state stuck. The only way to fix that behaviour is to switch
back to fully asynchronous code.
Upsides - way simpler code, and reduced amount of it.
Due to changes
useScreenOrientationalso affected.Checklist
useScreenOrientationanduseMediaQuerydon't update whenwindow.screen.orientation.lock("landscape")is called #849