Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create useRafEffect #693

Merged
merged 2 commits into from
Mar 30, 2022
Merged

feat: create useRafEffect #693

merged 2 commits into from
Mar 30, 2022

Conversation

JoeDuncko
Copy link
Contributor

What new hook does?

Like React.useEffect, but effect is only run within animation frame.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
    -Port remaining hooks from react-use #33
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@JoeDuncko JoeDuncko added the 🎂 new hook New hook added label Mar 28, 2022
@JoeDuncko JoeDuncko requested a review from xobotyi March 28, 2022 19:39
@JoeDuncko JoeDuncko self-assigned this Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #693 (75837c0) into master (369171c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #693   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        50    +1     
  Lines          857       865    +8     
  Branches       162       162           
=========================================
+ Hits           857       865    +8
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useRafEffect/useRafEffect.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da882cc...75837c0. Read the comment docs.

xobotyi
xobotyi approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@xobotyi xobotyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeDuncko JoeDuncko merged commit 6548831 into master Mar 30, 2022
@JoeDuncko JoeDuncko deleted the feat-useRafEffect branch March 30, 2022 17:11
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
@semantic-release-bot
chore(release): 13.2.0 [skip ci]
4ec6930 
# [13.2.0](v13.1.0...v13.2.0) (2022-03-30)

### Features

* create `useRafEffect` ([#693](#693)) ([6548831](6548831))
@xobotyi
Copy link
Contributor

xobotyi commented Mar 30, 2022

🎉 This PR is included in version 13.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobotyi xobotyi xobotyi approved these changes

Assignees

@JoeDuncko JoeDuncko

Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeDuncko @xobotyi