Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new hook useCustomCompareEffect #346

Merged
merged 2 commits into from
Sep 28, 2021
Merged

feat: new hook useCustomCompareEffect #346

merged 2 commits into from
Sep 28, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Sep 26, 2021

What new hook does?

Like useEffect but uses provided comparator function to validate dependencies change.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added ✨ enhancement New feature or request 🎂 new hook New hook added labels Sep 26, 2021
@xobotyi xobotyi requested a review from JoeDuncko September 26, 2021 18:37
@xobotyi
Copy link
Contributor Author

xobotyi commented Sep 26, 2021

should be merged after #345

@JoeDuncko JoeDuncko force-pushed the use-custom-compare-effect branch from dd80718 to 4c40152 Compare September 28, 2021 20:27
@xobotyi xobotyi force-pushed the use-custom-compare-effect branch from 4c40152 to 036502c Compare September 28, 2021 21:12
@xobotyi xobotyi force-pushed the use-custom-compare-effect branch from 036502c to f413849 Compare September 28, 2021 21:18
@JoeDuncko
Copy link
Contributor

Approved, made an issue to make an example #352

@JoeDuncko JoeDuncko merged commit ef4248a into master Sep 28, 2021
github-actions bot pushed a commit that referenced this pull request Sep 28, 2021
@semantic-release-bot
chore(release): 11.1.0 [skip ci]
dca7185 
# [11.1.0](v11.0.0...v11.1.0) (2021-09-28)

### Features

* new hook `useCustomCompareEffect` ([#346](#346)) ([ef4248a](ef4248a))
@xobotyi
Copy link
Contributor Author

xobotyi commented Sep 28, 2021

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xobotyi xobotyi deleted the use-custom-compare-effect branch December 8, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request 🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko