feat(useAsync): remove effector behaviour from hook #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use composition with effectors for such functionality. BREAKING CHANGE: `useAsync` hook now has only 2 arguments, `asyncFn` and `initialValue` and do not execute provided function on its own.
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 748 744 -4
Branches 133 132 -1
=========================================
- Hits 748 744 -4
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2021
# [10.0.0](v9.0.0...v10.0.0) (2021-09-23) ### Features * **useAsync:** remove effector behaviour from hook ([#339](#339)) ([0e47ff2](0e47ff2)) ### BREAKING CHANGES * **useAsync:** `useAsync` hook now has only 2 arguments, `asyncFn` and `initialValue` and do not execute provided function on its own. * chore(useAsync): remove unused `IUseAsyncOptions` interface
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use composition with effectors for such functionality.
BREAKING CHANGE:
useAsynchook now has only 2 arguments,asyncFnandinitialValueand do not execute provided function on its own.
How does this PR fix the problem?
Remove effector functionality and unnecessary arguments.
Checklist