fix: default useUnmountEffect example to false #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xobotyi
approved these changes
Apr 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 94.73% 95.52% +0.78%
==========================================
Files 10 11 +1
Lines 57 67 +10
Branches 5 5
==========================================
+ Hits 54 64 +10
Misses 3 3
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
## [1.9.1](v1.9.0...v1.9.1) (2021-04-28) ### Bug Fixes * default useUnmountEffect example to false ([#27](#27)) ([2ed0aa3](2ed0aa3))
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
The useMountEffect example triggers a dialogue when you leave the page by default, which is super annoying.
What changes does this PR make to fix the problem?
The useMountEffect example now requires user interaction before triggering a dialogue.
Checklist