Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useCookieValue from index #225

Merged
merged 1 commit into from
Jul 25, 2021
Merged

fix: remove useCookieValue from index #225

merged 1 commit into from
Jul 25, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jul 25, 2021

Because of optional dependency it would break the build in case of js-cookie absence.

BREAKING CHANGE: useCookieValue is no more exported from index file.

What new hook does?

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

Because of optional dependency it would break the build in case of `js-cookie` absence.

BREAKING CHANGE: `useCookieValue` is no more exported from index file.
@xobotyi xobotyi requested a review from JoeDuncko July 25, 2021 21:03
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #225 (788c0dc) into master (e393963) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines          725       724    -1     
  Branches       125       125           
=========================================
- Hits           725       724    -1     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e393963...788c0dc. Read the comment docs.

@xobotyi xobotyi merged commit c3b708d into master Jul 25, 2021
@xobotyi xobotyi deleted the fix_usecookievalue branch July 25, 2021 21:20
github-actions bot pushed a commit that referenced this pull request Jul 25, 2021
# [6.0.0](v5.0.0...v6.0.0) (2021-07-25)

### Bug Fixes

* remove `useCookieValue` from index ([#225](#225)) ([c3b708d](c3b708d))

### BREAKING CHANGES

* `useCookieValue` is no more exported from index file.
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 25, 2021

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants