Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new hook useAsync #119

Merged
merged 3 commits into from
Jun 14, 2021
Merged

feat: new hook useAsync #119

merged 3 commits into from
Jun 14, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 13, 2021 •
edited
Loading

What new hook does?

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@codecov
Copy link

codecov bot commented Jun 13, 2021 •
edited
Loading

Codecov Report

Merging #119 (e314b83) into master (faae68b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        31    +1     
  Lines          470       502   +32     
  Branches        84        87    +3     
=========================================
+ Hits           470       502   +32
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useAsync/useAsync.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82032be...e314b83. Read the comment docs.

@xobotyi xobotyi marked this pull request as ready for review June 13, 2021 14:01
@xobotyi xobotyi requested a review from JoeDuncko June 13, 2021 14:01
@xobotyi xobotyi added the 🎂 new hook New hook added label Jun 13, 2021
JoeDuncko
JoeDuncko approved these changes Jun 13, 2021
View reviewed changes
Copy link
Contributor

@JoeDuncko JoeDuncko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the add-new-hook.js question, LGTM

utility/add-new-hook.js

## Reference

\`\`\`ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added reference section to hook documentation template

@xobotyi xobotyi merged commit 54bbc00 into master Jun 14, 2021
github-actions bot pushed a commit that referenced this pull request Jun 14, 2021
@semantic-release-bot
chore(release): 1.28.0 [skip ci]
3019003 
# [1.28.0](v1.27.0...v1.28.0) (2021-06-14)

### Features

* new hook `useAsync` ([#119](#119)) ([54bbc00](54bbc00))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jun 14, 2021

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xobotyi xobotyi deleted the useAsync branch June 14, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko