fix(useMediaQuery): On misconfiguration, cause hydration error instea… #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 99.61% 99.62%
=======================================
Files 61 61
Lines 1049 1054 +5
Branches 166 169 +3
=======================================
+ Hits 1045 1050 +5
Misses 2 2
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xobotyi
approved these changes
Dec 7, 2022
|
🎉 This PR is included in version 20.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior, and the steps to reproduce the issue?
When the hook is misconfigured, that is, when
initializeWithValueistrueduring SSR, the hooks crashes instead of producing a hydration error, which is not in line with the behavior of the rest of the isomorphic hooks.What is the expected behavior?
Hydration error instead of a crash.
How does this PR fix the problem?
If the rendering environment is not a browser, set
initializeWithValuetofalse.This solution makes me wonder: what is the purpose of the
initializeWithValueoption anymore? If it is set tofalseduring SSR anyway, why have it at all? Is there a usecase for having the hook returnundefinedon first render when doing client-side rendering?Checklist
useMediaQueryhas the "correct" initial value #1000