Pr/remove hooks modifying head #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing this hook since it has been decided that hooks which modify contents of the head element should not be included in this library. BREAKING CHANGE: useDocumentTitle has been removed. re #386
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
- Coverage 99.61% 99.60% -0.01%
==========================================
Files 61 60 -1
Lines 1039 1025 -14
Branches 165 161 -4
==========================================
- Hits 1035 1021 -14
Misses 2 2
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM, but! we have to fix useStorageValue first |
xobotyi
approved these changes
Nov 8, 2022
|
One approving review and the CI is passing (coverage dropped merely because there's now fewer lines of code to test). Off to production we go! |
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
In #386 it was decided that hooks modifying the contents of the
<head>element should not be implemented and existing such hooks should be removed.What changes does this PR make to fix the problem?
useDocumentTitle(are there any other that should be removed?)useDocumentTitleanduseFaviconwith information about this decision and suggestion on using libraries such asreact-helmet.Closes #386