From 3d80787af7a005dd03c1cb632609a704c0ce4233 Mon Sep 17 00:00:00 2001
From: Michael Ellis <michael.ellis@vertexinc.com>
Date: Mon, 11 Apr 2022 09:10:41 -0400
Subject: [PATCH 1/5] Fixes roles

---
 src/Dialog/Content/index.tsx | 6 +++---
 src/Dialog/index.tsx         | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/Dialog/Content/index.tsx b/src/Dialog/Content/index.tsx
index f078078f..a1d11997 100644
--- a/src/Dialog/Content/index.tsx
+++ b/src/Dialog/Content/index.tsx
@@ -14,12 +14,12 @@ export type ContentProps = {
   onVisibleChanged: (visible: boolean) => void;
   onMouseDown: React.MouseEventHandler;
   onMouseUp: React.MouseEventHandler;
-} & IDialogChildProps
+} & IDialogChildProps;
 
 export type ContentRef = {
   focus: () => void;
   changeActive: (next: boolean) => void;
-}
+};
 
 const Content = React.forwardRef<ContentRef, ContentProps>((props, ref) => {
   const {
@@ -141,7 +141,7 @@ const Content = React.forwardRef<ContentRef, ContentProps>((props, ref) => {
       {({ className: motionClassName, style: motionStyle }, motionRef) => (
         <div
           key="dialog-element"
-          role="document"
+          role="dialog"
           ref={motionRef}
           style={{ ...motionStyle, ...style, ...contentStyle }}
           className={classNames(prefixCls, className, motionClassName)}
diff --git a/src/Dialog/index.tsx b/src/Dialog/index.tsx
index f33792c7..58fda75b 100644
--- a/src/Dialog/index.tsx
+++ b/src/Dialog/index.tsx
@@ -184,7 +184,6 @@ export default function Dialog(props: IDialogChildProps) {
         className={classNames(`${prefixCls}-wrap`, wrapClassName)}
         ref={wrapperRef}
         onClick={onWrapperClick}
-        role="dialog"
         aria-labelledby={title ? ariaIdRef.current : null}
         style={{ zIndex, ...wrapStyle, display: !animatedVisible ? 'none' : null }}
         {...wrapProps}

From e55652d179ea16840612ba95cef8a419a4b1c0b1 Mon Sep 17 00:00:00 2001
From: Michael Ellis <michael.ellis@vertexinc.com>
Date: Mon, 11 Apr 2022 09:13:50 -0400
Subject: [PATCH 2/5] Adds aria-modal attribute

---
 src/Dialog/Content/index.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/Dialog/Content/index.tsx b/src/Dialog/Content/index.tsx
index a1d11997..01f4fd3e 100644
--- a/src/Dialog/Content/index.tsx
+++ b/src/Dialog/Content/index.tsx
@@ -142,6 +142,7 @@ const Content = React.forwardRef<ContentRef, ContentProps>((props, ref) => {
         <div
           key="dialog-element"
           role="dialog"
+          aria-modal="true"
           ref={motionRef}
           style={{ ...motionStyle, ...style, ...contentStyle }}
           className={classNames(prefixCls, className, motionClassName)}

From 75c2a6344034147556a8aab9609f9525d69556fc Mon Sep 17 00:00:00 2001
From: Michael Ellis <michael.ellis@vertexinc.com>
Date: Tue, 12 Apr 2022 07:37:38 -0400
Subject: [PATCH 3/5] Updates snapshot

---
 tests/__snapshots__/index.spec.tsx.snap | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/__snapshots__/index.spec.tsx.snap b/tests/__snapshots__/index.spec.tsx.snap
index 113560a9..acd91fb6 100644
--- a/tests/__snapshots__/index.spec.tsx.snap
+++ b/tests/__snapshots__/index.spec.tsx.snap
@@ -9,13 +9,12 @@ exports[`dialog add rootClassName should render correct 1`] = `
   />
   <div
     class="rc-dialog-wrap"
-    role="dialog"
     style="font-size: 10px;"
     tabindex="-1"
   >
     <div
       class="rc-dialog"
-      role="document"
+      role="dialog"
       style="width: 600px; height: 903px;"
     >
       <div
@@ -58,12 +57,11 @@ exports[`dialog should render correct 1`] = `
   />
   <div
     class="rc-dialog-wrap"
-    role="dialog"
     tabindex="-1"
   >
     <div
       class="rc-dialog"
-      role="document"
+      role="dialog"
     >
       <div
         aria-hidden="true"

From 581b8d37c25f77e15c51bcc12b66c54c6dbc84d8 Mon Sep 17 00:00:00 2001
From: Michael Ellis <michael.ellis@vertexinc.com>
Date: Tue, 12 Apr 2022 08:15:11 -0400
Subject: [PATCH 4/5] Adds aria-modal to snapshot

---
 tests/__snapshots__/index.spec.tsx.snap | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/__snapshots__/index.spec.tsx.snap b/tests/__snapshots__/index.spec.tsx.snap
index acd91fb6..32b59ca1 100644
--- a/tests/__snapshots__/index.spec.tsx.snap
+++ b/tests/__snapshots__/index.spec.tsx.snap
@@ -15,6 +15,7 @@ exports[`dialog add rootClassName should render correct 1`] = `
     <div
       class="rc-dialog"
       role="dialog"
+      aria-modal="true"
       style="width: 600px; height: 903px;"
     >
       <div
@@ -62,6 +63,7 @@ exports[`dialog should render correct 1`] = `
     <div
       class="rc-dialog"
       role="dialog"
+      aria-modal="true"
     >
       <div
         aria-hidden="true"

From 23999f2178884237d5fc876e66b59f4f6884d2f2 Mon Sep 17 00:00:00 2001
From: Michael Ellis <michael.ellis@vertexinc.com>
Date: Tue, 12 Apr 2022 09:04:53 -0400
Subject: [PATCH 5/5] Moves aria-modal

---
 tests/__snapshots__/index.spec.tsx.snap | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/__snapshots__/index.spec.tsx.snap b/tests/__snapshots__/index.spec.tsx.snap
index 32b59ca1..c327fd52 100644
--- a/tests/__snapshots__/index.spec.tsx.snap
+++ b/tests/__snapshots__/index.spec.tsx.snap
@@ -13,9 +13,9 @@ exports[`dialog add rootClassName should render correct 1`] = `
     tabindex="-1"
   >
     <div
+      aria-modal="true"
       class="rc-dialog"
       role="dialog"
-      aria-modal="true"
       style="width: 600px; height: 903px;"
     >
       <div
@@ -61,9 +61,9 @@ exports[`dialog should render correct 1`] = `
     tabindex="-1"
   >
     <div
+      aria-modal="true"
       class="rc-dialog"
       role="dialog"
-      aria-modal="true"
     >
       <div
         aria-hidden="true"