Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Corrections and Enhancements #59

Open
paschulke opened this issue Jan 16, 2025 · 1 comment
Open

Documentation Corrections and Enhancements #59

paschulke opened this issue Jan 16, 2025 · 1 comment

Comments

@paschulke
Copy link

Issue: Documentation Corrections and Enhancements

1. Incorrect Description for SOCIALACCOUNT_AUTO_SIGNUP

Under Authentication Documentation:

  • Current Description:
    SOCIALACCOUNT_AUTO_SIGNUP = True forces new users to fill out a signup form even if the provider does provide the email address.

  • Correct Description:
    SOCIALACCOUNT_AUTO_SIGNUP = False forces new users to fill out a signup form even if the provider does provide the email address.

2. Database Initialization Required After Setting OIDC

When choosing OIDC (e.g. Keycloak) as an IDP, the database initialization must be repeated after the allauth Library Installation as described in the Database Initialization Documentation.

3. Mentioning the LOGIN_FORM Parameter

Including a reference to the LOGIN_FORM parameter in the authentication documentation All Auth documentation would be helpful for clarity and completeness.

4. Additional Profile Parameters

The following parameters should also be mentioned in All Auth documentation to clarify their role:

PROFILE_UPDATE = False
PROFILE_DELETE = False

5. TLS Certificate for On-Premise IDP Deployments

For on-premise IDP deployments (e.g. Keycloak), adding the TLS IDP Certificate to Python Packages is necessary unless an alternative implementation is provided by the project maintainers.

  • Example Command:
echo 'COMPANY CA
-----BEGIN CERTIFICATE-----
...
-----END CERTIFICATE-----' | sudo tee -a /srv/rdmo/rdmo-app/env/lib/python*/site-packages/certifi/cacert.pem

Suggested Actions

  1. Update the documentation for SOCIALACCOUNT_AUTO_SIGNUP to reflect the correct behavior.
  2. Add a note under OIDC configuration to repeat the database initialization step.
  3. Include references to the LOGIN_FORM, PROFILE_UPDATE, and PROFILE_DELETE parameters for better user guidance.
  4. Provide instructions or a note about adding TLS certificates for on-premise IDP deployments.

Thank you for considering these updates!

@MyPyDavid
Copy link
Member

thanks for the suggestions! I'll transfer this issue to our rdmo-docs repo.

@MyPyDavid MyPyDavid transferred this issue from rdmorganiser/rdmo Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants