Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding fcsSetter template in default config module #299

Merged
merged 12 commits into from
Jan 13, 2025
Merged

feat: Adding fcsSetter template in default config module #299

merged 12 commits into from
Jan 13, 2025

Conversation

kdivya153
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kdivya153 kdivya153 changed the base branch from main to dev December 19, 2024 15:55
@github-actions GitHub Actions
Copy link

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

@github-actions GitHub Actions
Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/Scripts/checkDefaultConfig.js
  71:15  error  'defaultContent' is never reassigned. Use 'const' instead  prefer-const
  72:15  error  'targetContent' is never reassigned. Use 'const' instead   prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@kdivya153 kdivya153 changed the title Firecert 2641 feat: Adding fcsSetter template in default config module Dec 19, 2024
kschrief
kschrief reviewed Jan 6, 2025
View reviewed changes
Scripts/checkDefaultConfig.js
// Remove comments from default content
const cleanedDefaultContent = defaultContent.replace(commentRegex, '');

// Merge contents, remove duplicates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if both the config module AND default module both have the same file being exported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging process add exports from defaultModule/index.js to configModule/index.js only if they don’t already exist, ensuring configModule content takes precedence.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/defaultModule/requestModules/fcsSetters.js
  222:1  error  Delete `⏎⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/defaultModule/requestModules/fcsSetters.js
  222:1  error  Delete `⏎⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@kdivya153 kdivya153 merged commit 9cbd8b8 into dev Jan 13, 2025
6 checks passed
@kdivya153 kdivya153 deleted the FIRECERT-2641 branch January 13, 2025 19:56
jbigel pushed a commit that referenced this pull request Jan 13, 2025
@semantic-release-bot
chore(release): 1.6.0-dev.7 [skip ci]
b57a3b0 
# [1.6.0-dev.7](v1.6.0-dev.6...v1.6.0-dev.7) (2025-01-13)

### Features

* Adding fcsSetter template in default config module ([#299](#299)) ([9cbd8b8](9cbd8b8))
* Linking ReadMe to fcsSetter ([#305](#305)) ([1f9b1d0](1f9b1d0))
@jbigel
Copy link
Contributor

jbigel commented Jan 13, 2025

🎉 This PR is included in version 1.6.0-dev.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
1849bcb 
# [1.6.0](v1.5.1...v1.6.0) (2025-01-15)

### Bug Fixes

* change jsonschema dependency to static 1.4.1 version ([#308](#308)) ([cdba6f4](cdba6f4))
* Fixed multiple app launch issue ([#302](#302)) ([b1199da](b1199da))
* quick fix for removing duplicates in the requestModule/index.js ([#310](#310)) ([53264db](53264db))
* Removed different test type name check ([#304](#304)) ([bbd526b](bbd526b))

### Features

* added glue code for dismissing an app ([#284](#284)) ([329cbbc](329cbbc))
* Adding fcsSetter template in default config module ([#299](#299)) ([9cbd8b8](9cbd8b8))
* Deep link implementation ([#268](#268)) ([6de90af](6de90af))
* Incorporated FCS setter into sendMessageToplatform ([#289](#289)) ([3b45e4d](3b45e4d))
* Linking ReadMe to fcsSetter ([#305](#305)) ([1f9b1d0](1f9b1d0))
@jbigel
Copy link
Contributor

jbigel commented Jan 15, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschrief kschrief kschrief approved these changes

Assignees
No one assigned
Labels
released on @dev released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdivya153 @CLAassistant @jbigel @kschrief