feat: "Add screenshot" button on local cuke reports #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jbigel
previously approved these changes
Nov 13, 2024
|
Hi Keaton: I am getting code matches in generic.js as well. Please will you add a comment under the Comcast header to say that it: so that the credit is clear here too. Thank you! |
|
b'## Copyright scan failure |
|
Hi @mhughesacn, I have added the requested comment. Please let me know if there is anything else I need to do in order for scans to pass on this pull request. Thanks in advance! |
jbigel
approved these changes
Nov 14, 2024
|
Thanks Keaton |
jbigel
pushed a commit
that referenced
this pull request
Nov 15, 2024
# [1.4.0-dev.11](v1.4.0-dev.10...v1.4.0-dev.11) (2024-11-15) ### Features * "Add screenshot" button on local cuke reports ([#261](#261)) ([bad0505](bad0505))
|
🎉 This PR is included in version 1.4.0-dev.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
# [1.4.0](v1.3.0...v1.4.0) (2024-11-27) ### Bug Fixes * added json object missing ([#259](#259)) ([2fc89e5](2fc89e5)) * Fixing clear event listener issue ([#243](#243)) ([b06818e](b06818e)) * null scenario to v2 ([#265](#265)) ([e30bd9c](e30bd9c)) * SDK report field for module runs ([#247](#247)) ([e6ad482](e6ad482)) ### Features * "Add screenshot" button on local cuke reports ([#261](#261)) ([bad0505](bad0505)) * [FCS] - Streamline dependencies on pub sub ([#224](#224)) ([e76863a](e76863a)) * discovery entity changes for 1.4 release of sdk ([#209](#209)) ([0bd0a3d](0bd0a3d)) * Enhancement of current performance scripts/code ([#248](#248)) ([5864c57](5864c57)) * Module certification issues 2 ([#242](#242)) ([5dcdbee](5dcdbee)) * Start/stop performance metrics collection for each test case without glue code ([#236](#236)) ([d909237](d909237)) * updated utils.js for getEnvVariable fix ([#246](#246)) ([6fe233e](6fe233e)) * Updating Scenario names ([#245](#245)) ([e3d2997](e3d2997)) * XSB accessibility cleanup ([#249](#249)) ([55b0547](55b0547)) * XSB Advertising module cleanup ([#251](#251)) ([6e457d0](6e457d0)) * XSB authentication cleanup ([#255](#255)) ([f4dd871](f4dd871)) * XSB discover launch hot cleanup ([#256](#256)) ([68987c7](68987c7)) * XSB discovery cleanup ([#258](#258)) ([55f5f7e](55f5f7e)) * XSB discovery launch cold cleanup ([#260](#260)) ([34f3f62](34f3f62)) * Xsb localization cleanup ([#222](#222)) ([4d3c746](4d3c746))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom logic to the cucumber reporting templates to add an "Add Screenshot" button to locally generated cucumber reports.